-
Notifications
You must be signed in to change notification settings - Fork 557
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Removes rank requirement from prosthetic limbs #6571
Removes rank requirement from prosthetic limbs #6571
Conversation
Removes the rank requirements and the section of code which checks for rank requirements on prosthetic limbs
removes additional description
I think it was removed because no bonebreaks/bleeding/pain is a bit too strong and does in fact provide a benefit. |
They don't have literal fractures, but they do break |
pretty sure it was removed because normal marines are supposed to be "ready for battle" with no disabilities nor mental problems when they are woken up for action its on discord somewhere |
Yes, but it's a lot easier to fix than a bonebreak that gives you debuffs even if splinted. |
Yet any rank can seemingly take the bad leg, which looks like a much more delibating sort of trait than having a robotic leg. Honestly, if it was made available for any non-squaddie role it'd be quite nice, as most of those don't go off running into combat (With IO's being a potential exception, though they're already able to take the robotic leg traits as 2nd LT's currently) |
Bad leg is a trait that was recently added , it's an oversight that You can take it as a combat role |
2024-06-27.11-34-46.mp4
Strangely enough? Robotic limbs DO feel pain when you get hurt. My presumption is that pain is handled through total damage to the person rather than individual limbs. |
As a genuine statement do you want me to just make a quick PR to make it so that you can't take Bad Leg as a combat role? Shouldn't be too hard to just put the same rank restriction that robotic limbs currently have on it. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
It'd be okay to have this for non-combat roles, but I don't want this for combat roles. I doesn't matter if they lose a limb mid-round and get a prosthetic during the round. But they shouldn't be trying to use traits for any balance reason. And yes if bad leg should get the same treatment where it can only be applied to non-combat roles. |
This PR has been inactive for long enough to be automatically marked as stale. This means it is at risk of being auto closed in ~ 7 days, please address any outstanding review items and ensure your PR is finished, if these are all true and you are auto-staled anyway, you need to actively ask maintainers if your PR will be merged. Once you have done any of the previous actions then you should request a maintainer remove the stale label on your PR, to reset the stale timer. If you feel no maintainer will respond in that time, you may wish to close this PR youself, while you seek maintainer comment, as you will then be able to reopen the PR yourself |
About the pull request
Removes the rank requirements and the section of code which checks for rank requirements on prosthetic limbs
Explain why it's good for the game
From a balance perspective, robotic limbs don't provide any benefit to those who have them and often are more of a detriment
From a fluff perspective, marines are given robotic limbs in round whenever they lose a limb, so it can be annoying if you want to add some more fluff to a character when they lost a limb last round and you aren't able to, even though you had one ten minutes ago.
Testing Photographs and Procedure
Tested on a local host. All works as it should
Screenshots & Videos
Changelog
🆑
del: Removed rank requirements for robotic limbs
/:cl: